search

Agoric / agoric-sdk

monorepo for the Agoric Javascript smart contract platform
Apache License 2.0
328 stars 206 forks source link

[Zoe] Move "myFirstDapp" out of contracts #746

Closed katelynsills closed 4 years ago

katelynsills commented 4 years ago

MyFirstDapp is a copy of SimpleExchange that has comments where users can/should add their own changes.

We don't actually need a copy of MyFirstDapp in zoe/contracts. This contract should only exist in a tutorial related to agoric-cli.

erights commented 4 years ago

On a stale branch I see https://github.com/Agoric/agoric-sdk/tree/delta-roles-params/packages/dapp-simple-exchange

I recommended removing the redundant myFirstDapp because I thought that one was still there. What happened to it? Was it mistakenly removed instead of removing the one in contracts?

katelynsills commented 4 years ago

Not sure what happened.

michaelfig commented 4 years ago

It has morphed into https://github.com/Agoric/dapp-simple-exchange/tree/master/contract/simple-exchange.js

michaelfig commented 4 years ago

I'm working on productionising it, because the old myFirstDapp didn't have enough features to support the UI in dapp-simple-exchange. Eventually, those features will make their way back into (or be done differently in) https://github.com/Agoric/agoric-sdk/tree/master/packages/zoe/src/contracts/simpleExchange.js

erights commented 4 years ago

On Sat, Mar 21, 2020 at 10:13 AM Michael FIG notifications@github.com wrote:

It has morphed into https://github.com/Agoric/dapp-simple-exchange/contract/simple-exchange.js

Did you mean https://github.com/Agoric/dapp-simple-exchange/blob/master/contract/simple-exchange.js ?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Agoric/agoric-sdk/issues/746#issuecomment-602074200, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACC3TCLJKYHFAA2WBW2ANTRITYR7ANCNFSM4LPXNKUA .

-- Cheers, --MarkM