Agoric / agoric-sdk

monorepo for the Agoric Javascript smart contract platform
Apache License 2.0
303 stars 191 forks source link

Switch from `babel-eslint` to `@babel/eslint-parser` #8379

Open mhofman opened 9 months ago

mhofman commented 9 months ago

What is the Problem Being Solved?

UI and dapps seem to rely on the deprecated babel-eslint which pukes on some ESM/CommonJS incompatibilities. Switching to @babel/eslint-parser fixes those problems

Description of the Design

Change deps in all repos

Security Considerations

As usual with changing dependencies, but this is from a trusted author

Scaling Considerations

None

Test Plan

Go through Getting Started step using latest packages from NPM

Upgrade Considerations

None

mhofman commented 6 months ago

@dckc not sure if this is still relevant, but it's an issue I encountered in some dapps

dckc commented 6 months ago

some ESM/CommonJS incompatibilities

got any specific examples?

mhofman commented 6 months ago

got any specific examples?

I cannot locate any, no