Agoric / agoric-sdk

monorepo for the Agoric Javascript smart contract platform
Apache License 2.0
322 stars 202 forks source link

`gen-upgrade-proposal.sh` should be scriptable #8784

Open mhofman opened 7 months ago

mhofman commented 7 months ago

What is the Problem Being Solved?

gen-upgrade-proposal.sh is a script to help the chain participant (usually a validator) generate a governance proposal transaction to upgrade an agoric-sdk based chain.

Some of the information must be provided, such as expected upgrade height, or upgrade name, and descriptions.

The script is currently outputting plain text instruction, including a command template meant to be copy/pasted with placeholders data for the above information. This results in the inability to script this process, and this helper script no longer being used for upgrades of the agoric-3 chain.

Description of the Design

Furthermore the script does not currently support indicating core proposal information, which is needed for upgrade-14

Security Considerations

The script must remain legible, especially around how the tx command is generated, for validators to trust its output.

Scaling Considerations

None

Test Plan

Manual?

Upgrade Considerations

This is to facilitate upgrade instructions, but has no bearing on the actual upgrade.

mhofman commented 5 months ago

9048 captures the need to change the upgrade info generated by the script.