Open mhofman opened 7 months ago
@mhofman I see we have already added some logging before/after restore from KVstore: https://github.com/Agoric/agoric-sdk/pull/8975
Are we looking for some other logging in this github issue?
Here are a few places I think are missing on snapshot creation (not as critical since validators don't pay close attentions to this):
SnapshotExtension
: this is when the cosmos side is done, and we're about to retrieve and add the swingset artifactsOnExportRetrieved
: this is after the artifact info has been retreived from the JS side. If JS is slower than cosmos to produce the artifacts, there will be a delay after the log entry of SnapshotExtension
.For snapshot restore, it's more important to provide regular progress, I think the following places are missing:
WriteSwingStoreExportToDirectory
, some way to track the progress of getting entries from exportDataReader
when writing to the exportDataFile
. I have found that this iteration can be quite slow.
What is the Problem Being Solved?
Some steps of state-sync restore such as exporting the swing-store shadow copy from IAVl, or importing the swing-store export take significant amount of time on the agoric-3 mainnet chain, which make it appear like the process has stalled or failed.
Description of the Design
Add some progress logging during these steps. In particular:
Test Plan
Perform a restore of mainnet using a patched agoric-sdk, and observe regular updates
Upgrade Considerations
Chain software upgrade, but technically this should be compatible without a consensus upgrade.