Agoric / agoric-sdk

monorepo for the Agoric Javascript smart contract platform
Apache License 2.0
326 stars 205 forks source link

Log progress during state-sync restore #8888

Open mhofman opened 7 months ago

mhofman commented 7 months ago

What is the Problem Being Solved?

Some steps of state-sync restore such as exporting the swing-store shadow copy from IAVl, or importing the swing-store export take significant amount of time on the agoric-3 mainnet chain, which make it appear like the process has stalled or failed.

Description of the Design

Add some progress logging during these steps. In particular:

Test Plan

Perform a restore of mainnet using a patched agoric-sdk, and observe regular updates

Upgrade Considerations

Chain software upgrade, but technically this should be compatible without a consensus upgrade.

Muneeb147 commented 1 month ago

@mhofman I see we have already added some logging before/after restore from KVstore: https://github.com/Agoric/agoric-sdk/pull/8975

Are we looking for some other logging in this github issue?

mhofman commented 1 month ago

Here are a few places I think are missing on snapshot creation (not as critical since validators don't pay close attentions to this):

For snapshot restore, it's more important to provide regular progress, I think the following places are missing: