search

Agoric / agoric-sdk

monorepo for the Agoric Javascript smart contract platform
Apache License 2.0
327 stars 207 forks source link

`endo-branch` integration does not affect docker based test #8938

Open mhofman opened 9 months ago

mhofman commented 9 months ago

Describe the bug

Most agoric-sdk tests support integrating with a endo packages built from a provided branch on the endojs repo, through capabilities of the restore-node action.

However that action is not used by docker based tests since the building of the SDK happens inside the docker image, not in CI.

This causes late bugs to be found when syncing endo, such as https://github.com/Agoric/agoric-sdk/pull/8923, with the first error showing up during a core eval.

To Reproduce

Open a PR with an endo-branch: master instruction in the description, add force:integration label.

Expected behavior

Docker based integration tests (deployment, aka loadgen, and docker-built-test, aka a3p) use endo packages build from endojs repo branch.

Platform Environment

CI

Additional context

I attempted to change that for the docker upgrade test but ran into complications of the resolutions packages not being found inside the image. There is some logic with porcelain checks that affect endo related changes that I don't fully grasp.

mhofman commented 5 days ago

A related problem with the docker upgrade test is that agoric-sdk dependencies of the proposal packages should be resolved to packages built from the surrounding sdk repo. However we inject endo resolutions, we should also inject resolutions for agoric-sdk packages.