search

Agoric / agoric-sdk

monorepo for the Agoric Javascript smart contract platform
Apache License 2.0
326 stars 206 forks source link

Upgrade scripts which rely on counting proposals #9019

Open JimLarson opened 7 months ago

JimLarson commented 7 months ago

What is the Problem Being Solved?

In cosmos-sdk 0.47, they removed telemetry for counting votes and proposals. It was incorrectly counting votes. They suggest using alternatives, such as state streaming. cosmos/cosmos-sdk#17910

We have some scripts that rely on counting proposals which need to be upgraded.

Description of the Design

Security Considerations

Scaling Considerations

Test Plan

Upgrade Considerations

dckc commented 7 months ago

We have some scripts that rely on counting proposals

For example?

JimLarson commented 6 months ago

@mhofman I've been asked to drive this, but could you please give me a pointer to the scripts you're concerned about?

mhofman commented 6 months ago

@mhofman I've been asked to drive this, but could you please give me a pointer to the scripts you're concerned about?

I don't specifically remember right now, but when auditing code which relied on query proposal, I noticed some surrounding code which relied on proposal count to guess the next proposal number. I think you can grep for proposal_id across our repos to find most location which may be involved with proposal querying. Looking for variants of gov proposal[s] might also lead you there.