search

Agoric / agoric-sdk

monorepo for the Agoric Javascript smart contract platform
Apache License 2.0
327 stars 206 forks source link

build SDK releases from an opt-out release branch on top of master #9417

Closed turadg closed 1 month ago

turadg commented 5 months ago

What is the Problem Being Solved?

Our release branches are made by cherry picking commits from master (opt-in to changes). We've come far enough along that we can invert this to being opt-out. That is, branch off master and then apply commits that revert any changes deemed unsafe. 

### Tasks
- [ ] Identify what behavior in master is not safe or yet feasible to deploy

Description of the Design

Security Considerations

Scaling Considerations

Test Plan

Upgrade Considerations

aj-agoric commented 5 months ago

Placed into @iomekam backlog since he is release manager for 16,

dckc commented 2 months ago

looks like as of upgrade-16, we're still doing opt-in:

this is based on looking at git log --graph --oneline origin/master origin/dev-upgrade-16 with master = 3c66f4b3bb and dev-upgrade-16 = 0df76a7105

iomekam commented 1 month ago

Our intention was to abide by going with an opt-out flow. However, by the time we started trying to perform the merging, the release branch wasn't in an ideal spot, and doing the merging would have been more overhead. Specifically, there were some changes that landed that would have complicated the merging.

We still released from master, we just did so by cherry-picking instead of merging.