Agoric / agoric-sdk

monorepo for the Agoric Javascript smart contract platform
Apache License 2.0
303 stars 191 forks source link

feat: make software upgrade `coreProposals` conditional on upgrade plan name #9575

Closed michaelfig closed 5 days ago

michaelfig commented 6 days ago

closes: #9571

Description

Parametrize the price feed core proposals by the upgrade handler name. The proposal for a3p remains with the deprecated ambient (from environment) oracle addresses.

Additionally fix and add some logging to the upgrade vault proposal

Security Considerations

None

Scaling Considerations

Not a typical scaling consideration, but this introduces a "basic" upgrade name that skips all vaults related proposals. The correctly parametrized info can be provided in the chain software upgrade proposal's upgrade info for any chain that has different configuration.

Documentation Considerations

Need to communicate to validators that the pattern of upgrade names has changed.

Testing Considerations

A3P and manually tested on mainfork

Upgrade Considerations

See above

cloudflare-pages[bot] commented 6 days ago

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: ea568a2
Status: ✅  Deploy successful!
Preview URL: https://6870a5d8.agoric-sdk.pages.dev
Branch Preview URL: https://mfig-cond-software-upgrade.agoric-sdk.pages.dev

View logs

mhofman commented 5 days ago

FYI I'm investigating why this is failing on mainfork, holding approval until then