search

Agoric / agoric-sdk

monorepo for the Agoric Javascript smart contract platform
Apache License 2.0
326 stars 205 forks source link

Patch @cosmjs/math for SES compatibility #9583

Closed kriskowal closed 3 months ago

kriskowal commented 3 months ago

closes: #9408

Description

Pending https://github.com/endojs/endo/pull/2330, we patch @cosmjs/math such that imports from ESM reflect the exported types.

Security Considerations

None.

Scaling Considerations

None.

Documentation Considerations

None.

Testing Considerations

Included test.

Upgrade Considerations

None.

cloudflare-workers-and-pages[bot] commented 3 months ago

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5852855
Status: ✅  Deploy successful!
Preview URL: https://c5e93326.agoric-sdk.pages.dev
Branch Preview URL: https://kriskowal-cosmjs-math-patch.agoric-sdk.pages.dev

View logs

mhofman commented 3 months ago

How does this address the original issue. A patch in agoric-sdk won't affect dapps if the dapp uses packages installed from NPM

kriskowal commented 3 months ago

How does this address the original issue. A patch in agoric-sdk won't affect dapps if the dapp uses packages installed from NPM

The fix for the underlying issue is https://github.com/endojs/endo/pull/2330