Agoric / agoric-sdk

monorepo for the Agoric Javascript smart contract platform
Apache License 2.0
303 stars 191 forks source link

Upgrading scaled price authority causes vaults upgrade to not complete #9584

Open mhofman opened 5 days ago

mhofman commented 5 days ago

Describe the bug

The vaults upgrade is a 2 step process where first new price feeds and auction contracts are installed, then the vault factory is upgraded only after a price quote on a new feed was received.

For some reason upgrading the scaled price authority before vaults factory completes its upgrade ends up failing the vaults upgrade.

Furthermore integration tests of vaults upgrade did not fail when this happened.

To Reproduce

run a3p tests on master

Expected behavior

No error, and an integration test catching vaults upgrade failures

Platform Environment

N/A

Additional context

Add any other context about the problem here.

Screenshots

If applicable, add screenshots to help explain your problem, especially for UI interactions.