refactor(orchestration): simplify example guest code - Githubissues

Agoric / agoric-sdk

monorepo for the Agoric Javascript smart contract platform

Apache License 2.0

303 stars 191 forks source link

refactor(orchestration): simplify example guest code #9586

Closed erights closed 3 days ago

erights commented 5 days ago

closes: #XXXX refs: https://github.com/Agoric/agoric-sdk/pull/9566/files#r1653602477

Description

At https://github.com/Agoric/agoric-sdk/pull/9566/files#r1653602477 @dckc commented on a cleanup that I thought I did and marked as done, but was not done.

Before #9566, the code that would be guest code had several workarounds marked // XXX when() until membrane that correctly indicated that they should be cleaned up as of #9566, which introduces exactly that membrane.

In addition, guest code has no need for heapVowE since it doesn't see vows. It should just use the normal E. To keep this distinct, I stopped renaming hostVowE where host code needs it in the same file.

Security Considerations

none

Scaling Considerations

none

Documentation Considerations

examples are now more like what we want to teach

Testing Considerations

I believe this PR is a pure refactor that should not have any observable effects. Thus, it should not affect any tests. We'll see soon.

Upgrade Considerations

none

cloudflare-pages[bot] commented 5 days ago

Deploying agoric-sdk with Cloudflare Pages

Latest commit:	`0bd6dd0`
Status:	✅ Deploy successful!
Preview URL:	https://22071b22.agoric-sdk.pages.dev
Branch Preview URL:	https://markm-simplify-guest-code.agoric-sdk.pages.dev