9382 upgraded the scaledPriceAuthorities, but seems to have broken the vaultFactory update. This casts doubt on the performance measurements in #9371. (If the price updates weren't getting through at all, that would be sufficient to explain the complete lack of memory growth.)
The current hypothesis is that the way the scaledPriceAuthority upgrade interfered with the upgrade was that it broke the priceFeedPromises being awaited in the upgrade-vaults proposal. This meant the vault upgrade was not triggered, so it didn't switch to new priceFeeds or the new Auction.
The way price updates were sent during performance measurement should have led to the priceFeed vats creating quote payments, which is where the memory leak happens, so maybe the measurement was okay.
Description of the Design
Redo the measurements and verify that the vaultFactory upgrade took place and prices propagated to auctions and vaults.
What is the Problem Being Solved?
9382 upgraded the scaledPriceAuthorities, but seems to have broken the vaultFactory update. This casts doubt on the performance measurements in #9371. (If the price updates weren't getting through at all, that would be sufficient to explain the complete lack of memory growth.)
The current hypothesis is that the way the scaledPriceAuthority upgrade interfered with the upgrade was that it broke the priceFeedPromises being awaited in the upgrade-vaults proposal. This meant the vault upgrade was not triggered, so it didn't switch to new priceFeeds or the new Auction.
The way price updates were sent during performance measurement should have led to the priceFeed vats creating quote payments, which is where the memory leak happens, so maybe the measurement was okay.
Description of the Design
Redo the measurements and verify that the vaultFactory upgrade took place and prices propagated to auctions and vaults.
Security Considerations
None
Scaling Considerations
This is about measuring scaling impact.
Test Plan
See above.
Upgrade Considerations
See above.