search

Agoric / agoric-sdk

monorepo for the Agoric Javascript smart contract platform
Apache License 2.0
303 stars 191 forks source link

vlocalchain core proposal failure on devnet #9603

Closed mhofman closed 2 days ago

mhofman commented 3 days ago

Describe the bug

The vlocalchain core proposal failed when upgrading devnet to u16. Unfortunately because of https://github.com/Agoric/agoric-sdk/issues/8441, we couldn't panic the upgrade.

To Reproduce

Unfortunately none? But we have slogs and logs. I can also dig out a snapshot preceding upgrade-16 if we want to replay.

Expected behavior

No error

Platform Environment

Devnet executing upgrade-16

Additional context

It's possible that devnet had some previous network related vats that interfered with this.

Screenshots

2024-06-26T11:09:11.896Z SwingSet: vat: v1: coreProposal: setupLocalChainVat
2024-06-26T11:09:11.897Z SwingSet: vat: v1: createVat(b1-6c46bc31b25a77394560711e227fe00e6f73ef2719cc6e2799b51ce50407cfce3eccc8f74118d69880184eca9fcb02244d23da1eb9ea4d943f6293fd5af8f812)
2024-06-26T11:09:12.511Z SwingSet: vat: v1: execute { manifestGetterName: 'getManifestForTransfer', bundleExports: [ 'getManifestForTransfer', 'setupTransferMiddleware' ] }
2024-06-26T11:09:12.512Z SwingSet: vat: v1: vtransferBridgeManager: new Promise
2024-06-26T11:09:12.528Z SwingSet: vat: v1: coreProposal: setupTransferMiddleware
2024-06-26T11:09:12.529Z SwingSet: vat: v1: createVat(b1-a662be823b04d334bf622de9dc525bbd8453e622cef65ff29431640ba42d2ededa8e4324d3454d3c73d952429d62dfecf71a91e259a251116afd1185befc4144)
2024-06-26T11:09:12.615Z SwingSet: ls: v15: Logging sent error stack (TypeError#1)
2024-06-26T11:09:12.616Z SwingSet: ls: v15: TypeError#1: target has no method getPortAllocator , has [ 'bind', 'registerProtocolHandler', 'unregisterProtocolHandler' ]
dckc commented 3 days ago

It's possible that devnet had some previous network related vats that interfered with this.

Quite. https://devnet.agoric.net/ shows Revision: 94e82e6d6234466f6c06b56caf072fdd32876807 (p.s. oops; that's too new to be the relevant version)

where we find:

https://github.com/Agoric/agoric-sdk/blob/94e82e6d6234466f6c06b56caf072fdd32876807/packages/vm-config/decentral-devnet-config.json#L10-L14

mhofman commented 3 days ago

that's what devnet is running now, because it was upgraded, not what it started with

dckc commented 3 days ago

Was devnet genesis after May 2023? after Feb 2024?

It looks like including the network vat and such in devnet-config goes back at least to May 2023 https://github.com/Agoric/agoric-sdk/commit/68c8363dea5aa4f2f1846e053ccd68d4e6a9131c

localchain was added Feb 26 19e5aed4e8a2aad667c04023e0aea01712ff9b9c

aj-agoric commented 2 days ago

closing as not an expected scenario