xsnap doesn't rebuild when make env changes - Githubissues

Agoric / agoric-sdk

monorepo for the Agoric Javascript smart contract platform

Apache License 2.0

303 stars 191 forks source link

xsnap doesn't rebuild when make env changes #9614

Closed mhofman closed 9 hours ago

mhofman commented 2 days ago

Describe the bug

Changing env passed to xsnap doesn't cause xsnap to rebuild, even though the env would affect the build output.

This recently caused app hashes for a validator on devnet (https://github.com/Agoric/agoric-sdk/issues/9602), and also results in the updated package version to not be included in the output.

To Reproduce

Checkout something like agoric-upgrade-10 ... agoric-upgrade-15 which all have the same xsnap submodule deps.
build
checkout in the same repo a more recent version up to agoric-upgrade-16-rc0
build
observe that xsnap-worker -v returns the wrong package version (note that u15 does not actually change the xsnap package version)

Expected behavior

Rebuild of xsnap on upgrades which change anything about xsnap

Additional context

This is tangentially related to #7012 since we'd need to force a rebuild if the version is plumbed through as env.