[x] Offer shapes - 1 of 3 makeInvitation calls has an offer shape; is that enough?
Depends on Client docs - n/a (client side)
Lesson plan + video - n/a
It's a minimal effort job. I copied test-swap-wallet.js from dapp-swaparoo, ran it, and then fixed the errors until it passed. In all cases, copying verbatim from dapp-swaparoo sufficed.
Reviewers: please distinguish correctness feedback from style. Here's hoping we find time to make the code exemplary in style as well as correct, but I'm not sure how much of that we should do at this point.
refs https://github.com/Agoric/dapp-agoric-basics/issues/9
This meets all the requirements I know of (oops; save 1... deploying on chain):
from https://github.com/Agoric/documentation/issues/940 :
makeInvitationcalls has an offer shape; is that enough?It's a minimal effort job. I copied
test-swap-wallet.jsfrom dapp-swaparoo, ran it, and then fixed the errors until it passed. In all cases, copying verbatim from dapp-swaparoo sufficed.Reviewers: please distinguish correctness feedback from style. Here's hoping we find time to make the code exemplary in style as well as correct, but I'm not sure how much of that we should do at this point.