Agoric / dapp-agoric-basics

This is a simple app for the Agoric smart contract platform.
0 stars 4 forks source link

increase test fidelity with makeWalletFactoryDriver from @agoric/boot #23

Open dckc opened 8 months ago

dckc commented 8 months ago

The mockWalletFactory here has subtle / undocumented limitations.

https://github.com/Agoric/dapp-agoric-basics/blob/53c139c8419c54d4c0a59e5aef49e5c088af5459/contract/test/wallet-tools.js#L35

would be nice to use something like...

import { makeWalletFactoryContext } from './walletFactory.ts';

perhaps by copying that file.

The imports don't seem to be released yet or something.

$ mkdir wf
$ cd wf
$ yarn add @agoric/boot
$ ls node_modules/@agoric/boot/tools/
authorityViz.d.ts  authorityViz.d.ts.map  authorityViz.js  viz.mk

$ grep boot package.json 
    "@agoric/boot": "^0.1.1-dev-9f8a76e.0"

cc @turadg

turadg commented 8 months ago

Oh, that's because NPM for the package hasn't updated in 7 months and that's because@agoric/boot was made private 7 months ago https://github.com/Agoric/agoric-sdk/commit/97d4ec5b709a1461faadeec9517a08ed1a22c7ed

I think the rationale was that it's not designed to be an external dependency. If we are going to publish these modules and maintain them for external consumption, I think Product should be involved. We might also want to revisit the factoring.