Agoric / dapp-agoric-basics

This is a simple app for the Agoric smart contract platform.

0 stars 2 forks source link

how to keep in sync with dapp-offer-up? #4

Open dckc opened 5 months ago

dckc commented 5 months ago

PR #6 inherited...

[x] support for starting a local chain a la yarn start:docker in dapp-offer-up
[x] something like yarn start:contract (cf https://github.com/Agoric/dapp-offer-up/issues/5 )
[x] add endo resolutions to control bundle size (cf https://github.com/Agoric/dapp-offer-up/issues/28 )
[x] test that bundle size didn't blow up (cf https://github.com/Agoric/dapp-offer-up/issues/36 )

But maintaining this dapp independently from dapp-offer-up means addressing these issues in both repositories:

[ ] test that the chain is available before using it (cf https://github.com/Agoric/dapp-offer-up/issues/27 )
[ ] test that contract got deployed (cf https://github.com/Agoric/dapp-offer-up/issues/46 )
[ ] handle out-of-IST (cf https://github.com/Agoric/dapp-offer-up/issues/60 )
[ ] clean up log output (cf https://github.com/Agoric/dapp-offer-up/issues/62 )

More along those lines, not directly related to contract deployment (perhaps belongs in a separate issue)

[ ] yarn 4: https://github.com/Agoric/dapp-offer-up/issues/40
[ ] ci: https://github.com/Agoric/dapp-offer-up/issues/48

dckc commented 4 months ago

6 copied the `yarn start:contract` stuff from dapp-agoric-basics.

I'll re-scope this to managing the remaining duplicate work.

dckc commented 2 months ago

https://github.com/Agoric/dapp-offer-up/commit/142bf9af874794a73281ce3ab49fc2522eb7d645 is another bit of dapp-offer-up that should be here.

dckc commented 2 months ago

bundle size test refinement is not in dapp-offer-up

https://github.com/Agoric/dapp-agoric-basics/blob/f48420eb0a556d972ded1dbc4d66bf2bc6afa6d8/contract/test/test-build-proposal.js#L64-L65

https://github.com/Agoric/dapp-offer-up/blob/5a3999fb8e38a6c940a8de5b7a664d994bb0e010/contract/test/test-build-proposal.js