search

Agoric / dapp-agoric-basics

This is a simple app for the Agoric smart contract platform.
0 stars 3 forks source link

feat: pay ui #45

Closed samsiegart closed 1 month ago

samsiegart commented 1 month ago

fixes https://github.com/Agoric/documentation/issues/1001 fixes https://github.com/Agoric/dapp-agoric-basics/issues/46

The UI is almost a copy-paste of the swap UI with the "Want" removed and a different makeOffer call.

Changed the postal service contract to be able to add issuers from invitation args, so swapping tickets works (https://github.com/Agoric/dapp-agoric-basics/issues/46)

Also removed an unused vbank query and added contract/,tx.json to gitignore.

Screenshot

image

samsiegart commented 1 month ago

Adding @dckc as a reviewer for the contract bits

samsiegart commented 1 month ago

thought: since we have docs for our templates, should we consider including descriptions where we use @param etc, then we can just generate the docs for our templates. I know we use it for type reasons primarily.

This is a good option to have, but I don't have a vision of which docs we'd want to generate for this specifically. It's more useful for component libraries, but we can't import parts of dapp-agoric-basics in another project.