search

Agoric / dapp-agoric-basics

This is a simple app for the Agoric smart contract platform.
0 stars 4 forks source link

Linting dapp-agoric-basics #67

Closed mujahidkay closed 2 months ago

mujahidkay commented 2 months ago

Description

This PR enables tsc and fixes lint errors for this dapp. Majority of the code is typed now apart from a few instances where I either had to self-define some types or leave them as TO-DOs for future.

Have segregated the types of files by commits so can be reviewed commit by commit.

mujahidkay commented 2 months ago

@turadg I've addressed the comments except for https://github.com/Agoric/dapp-agoric-basics/pull/67#discussion_r1779021051 . It wouldn't allow me to type cast it to a Amount<'copyBag'>. I have kept this as is and specified the kind when defining the Brand in Inventory. Comments addressed upto e192627

The last two commits are just cleanups. I will rebase and squash commits before merging the PR (as per your suggestion).