ci: change docker-compose to docker compose

Agoric / dapp-econ-gov

Governance UI for Inter Protocol economic committee

0 stars 3 forks source link

ci: change docker-compose to docker compose #110

Closed frazarshad closed 1 month ago

frazarshad commented 1 month ago

Closes: #111

Fixes some flakes in e2e testing.

Firstly used docker compose instead of docker-compose (which is not being recognized by github actions)
Secondly removed some unnecessary steps to give some space to the github runner, otherwise the job was failing due to space limit being reached

cloudflare-pages[bot] commented 1 month ago

Deploying dapp-econ-gov with Cloudflare Pages

Latest commit:	`324729d`
Status:	✅ Deploy successful!
Preview URL:	https://fd00d9a0.dapp-econ-gov.pages.dev
Branch Preview URL:	https://fraz-use-docker-compose-v2.dapp-econ-gov.pages.dev

View logs

github-actions[bot] commented 1 month ago

Cloudflare deployment logs are available here

rabi-siddique commented 1 month ago

there were some errors related to space running out for the runner

Do we know the cause of this issue? Is there a chance it could occur in other dapps where we've implemented e2e tests? Should we consider applying this change across all our dapps?

frazarshad commented 1 month ago

Do we know the cause of this issue? Is there a chance it could occur in other dapps where we've implemented e2e tests? Should we consider applying this change across all our dapps?

Dont really know the root cause. probably due to some increase in the size of our containers.

This probably can become an issue for our other dapps so i've created PRs for them too

frazarshad commented 1 month ago

@rabi-siddique added the issue

rabi-siddique commented 1 month ago

@rabi-siddique added the issue

LGTM. Let's merge this.