search

Agoric / dapp-fungible-faucet

A simple dapp that mints and sends fungible tokens to a user's wallet
3 stars 8 forks source link

chore: Patch ESM for migration #23

Closed kriskowal closed 3 years ago

kriskowal commented 3 years ago

This change patches RESM so dependencies in Agoric SDK can migrate away.

katelynsills commented 3 years ago

@kriskowal I noticed in the dapp-card-store PR, the contract package.json got changed too. Is that required for this dapp too?

kriskowal commented 3 years ago

It turns out to not be required at all. I’m on the fence as to whether it should also be in every package.json.

katelynsills commented 3 years ago

It turns out to not be required at all. I’m on the fence as to whether it should also be in every package.json.

If it's not required, it's probably best to leave out such that the developers who clone this see a minimal amount of unusual things. The only request I would have is that whatever we choose, we should make sure it's the same for all dapps. That would mean removing the additional changes in dapp-card-store. Ok if I make an issue for that, and assign it to you? This would be a low priority issue.

kriskowal commented 3 years ago

I can follow-up back on dapp-card-store, will keep this open to track.