search

Agoric / dapp-inter

User application for Agoric Inter Protocol—Vaults, BLD Boost, Liquidations, etc.
2 stars 10 forks source link

User can unknowingly create/adjust a vault that quickly becomes liquidated #101

Closed otoole-brendan closed 1 year ago

otoole-brendan commented 1 year ago

What is the Problem Being Solved?

UI work that compliments #6968 - see for more information that is adequately described there.

Description of the Design

Vaults UI work for underlying contract work spec'd as https://github.com/Agoric/agoric-sdk/issues/6968

(use lower price between current oracle price or next liquidation price when creating a vault or adjusting a vault (minting more IST) in lieu of MCR-LR calculation in avoid unwitting liquidation situations.

Security Considerations

Test Plan

otoole-brendan commented 1 year ago

Another for the V+1 for now but add back in when 0 pile

otoole-brendan commented 1 year ago

@samsiegart just confirming something I believe we already discussed - as it stands, this will be enforced on a contract-level so user will get offer error in wallet UI? (assuming they use endorsed UI - I understand there is a risk that they could a different UI which could circumvent this - but I'll admit I don't fully understand how)