Agoric / dapp-inter

User application for Agoric Inter Protocol—Vaults, BLD Boost, Liquidations, etc.
2 stars 10 forks source link

Proposed Debt exceed max value for collateral error in Wallet UI when submitting vault creation offer #113

Closed otoole-brendan closed 1 year ago

otoole-brendan commented 1 year ago

Describe the bug

Getting below error in Wallet UI upon attempting to approve vault creation transaction (following txn signing in Keplr):

image.png

To Reproduce

Steps to reproduce the behavior:

  1. Go to Vaults UI
  2. Submit create vault offer
  3. Approve in Wallet UI
  4. Sign Keplr transaction
  5. Get error

Expected behavior

Vault should be created

Platform Environment

Additional context

Add any other context about the problem here.

Screenshots

If applicable, add screenshots to help explain your problem, especially for UI interactions.

samsiegart commented 1 year ago

More context: The UI displays a price of 14.5, with 175% MCR. The numbers in the screenshot above appear to be enforcing a price of 0.151, which was the result of a previous price round. However, the price was since updated to 14.5, which the UI sees, but the contract doesn't seem to be enforcing.

@turadg @dckc I'm soliciting some input here, I'm thinking either the UI or the contract is reading the price from the wrong source. The UI is watching manager0.quotes, is that correct? How can we make sure the contract and UI are in sync?

rowgraus commented 1 year ago

Still seeing this issue which is blocking testing

rowgraus commented 1 year ago

Created issue in agoric-sdk (7670). Closing this issue in favor of that