search

Agoric / dapp-inter

User application for Agoric Inter Protocol—Vaults, BLD Boost, Liquidations, etc.
2 stars 10 forks source link

before "connect wallet", ATOM balance shows 0 when >0 is in my wallet #119

Closed dckc closed 1 year ago

dckc commented 1 year ago

Describe the bug

To Reproduce

what I did, anyway:

  1. used https://devnet.faucet.agoric.net/ to get some devnet BLD, ATOM
  2. Use https://main.wallet-app.pages.dev/wallet/ to provisioned a smart wallet; saw 500 ATOM
  3. went to https://app.inter.trade/?network=devnet
  4. saw 0 ATOM Available

Expected behavior

Show "??? ATOM Available" or omit that field or something.

Platform Environment

brave on linux. I don't think I'm using node nor the sdk

Inter protocol link includes bafybeih3ieyxyphvnbwsk7ahmgk232z3tndfbuxth7y5273shhgz5juore

instagoric shows Chain: agoricdev-18 Revision Link: https://github.com/Agoric/agoric-sdk/tree/ea8c1c64911b4c58fb43635b25e17e3d50d0cf2a

Screenshots

image

samsiegart commented 1 year ago

I think the 0.00 balance is explainable enough with the big red "need to connect wallet" text that was cropped out:

Screenshot 2023-05-20 at 12 16 10 PM

We could consider moving that text to replace where it shows 0.00 ATOM available though. I think "???" is too unsightly as a placeholder, also considered "--" or something but in this context it doesn't seem as clear that it's referring to a balance.

otoole-brendan commented 1 year ago

I agree with @samsiegart here - we're training users to know this is where to check balance without having to glance at their wallet (once connected) and seeing a 0 balance alongside 'Need to connect wallet' red text is pretty intuitive imo. Besides, showing 0 balance before wallet connection is a standard UX practice in DeFi from what I've researched (can point to many app chains in Cosmos that do so so there is clear precedent). My recommendation would be that we close this out as design is acceptable and clear as is.