Agoric / dapp-inter

User application for Agoric Inter Protocol—Vaults, BLD Boost, Liquidations, etc.
2 stars 10 forks source link

Vaults stuck in liquidating state following reconstitution/price change #132

Closed otoole-brendan closed 1 year ago

otoole-brendan commented 1 year ago

Describe the bug

After testing reconstitution scenario on Emerynet (which was successful) - the two reconstituted vaults were liquidated again in the next auction (expected). While in a state of 'liquidating' - I changed the price to 12.34 (previously 9.99). Even thought the auction finishes, the vaults never leave the liquidating state (i.e. they are not reconstituted, at least per the UI). I'm unable to take action/click etc.

Looks like this

To Reproduce

Steps to reproduce the behavior:

  1. Test Reconstitution liquidation scenario (or I suspect happy path)
  2. When vault is in a state of 'liquidating' - change the price to something higher than liquidation price i.e. 12.34
  3. Oberve when auction finishes if vaults complete liquidation/are reconstituted

Expected behavior

Changing price during liquidation should not break/hang the state of the vaults in the UI

Platform Environment

Additional context

Add any other context about the problem here.

Screenshots

image.pngIf applicable, add screenshots to help explain your problem, especially for UI interactions.

rowgraus commented 1 year ago

Metrics show that the vaults have correctly reconstituted. However, the status is stuck as Liquidating, which prevents the user from adjusting their vault in the UI

image
otoole-brendan commented 1 year ago

Issue moved to Agoric/agoric-sdk #7850 via Zenhub