fix: connect wallet button bugs

Agoric / dapp-inter

User application for Agoric Inter Protocol—Vaults, BLD Boost, Liquidations, etc.

2 stars 10 forks source link

fix: connect wallet button bugs #147

Closed samsiegart closed 1 year ago

samsiegart commented 1 year ago

Don't let the user click connect until chainStorageWatcher is initialized (which happens after network config is fetched). That's because makeAgoricWalletConnection requires it.
Fix the loading spinner animation. We changed the css variables and that broke the styles there.

github-actions[bot] commented 1 year ago

Network: Commit: a8a94f3b36b85640a2e7514e38fd32b994a5db05 Ref: refs/heads/main IPFS v1 hash: bafybeiatwbvnk6bpl7ackn5vvkcnktwl3rteiklyt2nsutkbmjze2souym CF - DWeb - 4EVERLAND

samsiegart commented 1 year ago

What would it take to have regression tests for these?

For the style fix, I think that might be tricky. Possibly some type of screenshot testing, but with an animation like that it might not be reliable to test.

For the button thing, I think a component test with vitest and mocking the store would be doable