search

Agoric / dapp-inter

User application for Agoric Inter Protocol—Vaults, BLD Boost, Liquidations, etc.
2 stars 7 forks source link

feat: deposit ist from provision dialog #227

Closed samsiegart closed 3 months ago

samsiegart commented 5 months ago

fixes https://github.com/Agoric/dapp-inter/issues/244

Screenshot 2024-03-14 at 10 27 40 AM
github-actions[bot] commented 5 months ago

Network: Commit: aa28174f0458bd4564c8405da6c2a80f3a9eb85c Ref: refs/heads/main IPFS v1 hash: bafybeid6mivism3zbaybc4lvu55vf7koadq4p3jseswjozxfdabfsz2mum CF - DWeb - 4EVERLAND

otoole-brendan commented 4 months ago

@samsiegart the one change I would make (and you might already be doing it but not visible here) is some logic around when a user can click 'Proceed'. I think it's better UX to not let them attempt the transaction by hitting 'Proceed' until they have at least 1IST balance to cover the smart wallet provisioning. So we should only illuminate the button when they have that required balance.

samsiegart commented 3 months ago

@ivanlei I updated the text in the dialog per @raphdev 's suggestion, lmk if this looks good to you.

samsiegart commented 3 months ago

Ran into #252 while testing, but appears to be unrelated. LGTM after the copy edit.

The breaking change has now been reverted and this PR has been rebased