Minting fee

[samsiegart]

fixes https://github.com/Agoric/dapp-inter/issues/247 fixes https://github.com/Agoric/dapp-inter/issues/248

Screenshots

Adjust Vault Minting Fee Text

Adjust Vault Tooltip + Minting Fee

Create Vault Tooltip

[github-actions[bot]]

Network: Commit: 1a56adcdb5b855f2558caec068ed32ce194433cf Ref: refs/heads/main IPFS v1 hash: bafybeid3erogni4drbgww6dafwzgxws62jr3nbzc2gwcxwfpsfht2fw6iu CF - DWeb - 4EVERLAND

[samsiegart]

I made some adjustments apart from the latest comment on https://github.com/Agoric/dapp-inter/issues/248.

In particular, in "Adjust Vault", I didn't add the "Minting" line because there's nothing to show on the left of the arrow so it looked odd (we don't know the total amount minted from a particular vault, only its debt). Also, the contents of the tooltip as suggested: Existing debt (1100) + minting fee (50) + accrued stability fee (X) didn't seem quite right, because existing debt includes stability fee already, and we need to add the newly minted amount to that equation instead. Also, I didn't include the values because it seemed kinda noisy for a tooltip, but could add them back if needed.

[otoole-brendan]

@samsiegart

Some changes to improve consistency:

Adjust Vault: Change 'Debt' -> 'Your Debt Balance' (tool tip and its contents looks good so let's keep them)

Create Vault: Similarly the tool tip and contents work well here but I noticed the line items for create vault could do with re-ordering to more intuitive and to match 'Adjust Vault'. This includes:

• Move 'Collateralization Ratio' to be above the line
• Move 'Stability Fee' and 'Minimum Collateralization Ratio' below the line.

The rationale with the delineating line was to visually separate the static fees/rates (below the line) and the dynamic/vault-specific information (above the line). This might be a little out of the scope of this change but I think it's easier to address with this PR and does simplify UX nicely

[samsiegart]

@otoole-brendan Thanks for taking a look, makes sense. Just adjusted as shown:

[otoole-brendan]

@samsiegart looks good but the order of line items below line for adjust vault and create vault differs. The ordering for adjust vault is best imo so can you change the create vault order to match adjust vault ordering? (just the below the line pieces)

[samsiegart]

Updated the ordering in create-vault: