test: add test for verifying https://app.inter.trade url

Agoric / dapp-inter

User application for Agoric Inter Protocol—Vaults, BLD Boost, Liquidations, etc.

2 stars 7 forks source link

test: add test for verifying https://app.inter.trade url #266

Closed rabi-siddique closed 1 month ago

rabi-siddique commented 2 months ago

The PR does the following:

Add a test for verifying https://app.inter.trade/ URL is functional.
Add a test for setting up a wallet. Previously, this setup was managed by the before hook, as configured in @agoric/synpress here. However, this approach led to unexpected behavior when dealing with multiple origins in tests. It functioned correctly with a single origin but it became tedious when testing multiple origins, as the before callback ran each time the origin changed. To address this issue, I've created a separate test case for setting up the wallet and have overridden the support.js file.

rabi-siddique commented 2 months ago

I'm not sure that testing that the prod URL is live in CI is desirable, is there more context about the motivations for this? I could see a test in https://github.com/Agoric/dapp-inter-jumper being more useful for loading a local version of the UI and verifying that it redirects to the appropriate ReferencedUI

Ah, got it. The reason I included this test is because it's mentioned in our end-to-end test sheet for dapp-inter. Here. I'll verify it with Brendon and get back to you!

rabi-siddique commented 2 months ago

I'm not sure that testing that the prod URL is live in CI is desirable, is there more context about the motivations for this? I could see a test in https://github.com/Agoric/dapp-inter-jumper being more useful for loading a local version of the UI and verifying that it redirects to the appropriate ReferencedUI

@samsiegart should we make it part of the periodic run of dapp-inter test cases with emerynet over here #261

samsiegart commented 2 months ago

@samsiegart should we make it part of the periodic run of dapp-inter test cases with emerynet over here https://github.com/Agoric/dapp-inter/pull/261

I think it would be best to put these in dapp-inter-jumper and run as part of CI against a local build, and also against emerynet periodically. Otherwise, yea I'm okay with just running them periodically against emerynet/live URL. However, don't the test cases in https://github.com/Agoric/dapp-inter/pull/261 run in CI as well as periodically? Or can they be separated?

rabi-siddique commented 2 months ago

@samsiegart should we make it part of the periodic run of dapp-inter test cases with emerynet over here #261

I think it would be best to put these in dapp-inter-jumper and run as part of CI against a local build, and also against emerynet periodically. Otherwise, yea I'm okay with just running them periodically against emerynet/live URL. However, don't the test cases in #261 run in CI as well as periodically? Or can they be separated?

Yes, test cases in #261 run in CI periodically. Separated as in?

samsiegart commented 2 months ago

Separated as in?

It looks like we have one workflow file that runs both in PRs and periodically. I'm suggesting that for the test cases that depend on live versions of apps, rather than locally built versions, we create a separate workflow for them so that they don't run in PRs.

rabi-siddique commented 2 months ago

Separated as in?

It looks like we have one workflow file that runs both in PRs and periodically. I'm suggesting that for the test cases that depend on live versions of apps, rather than locally built versions, we create a separate workflow for them so that they don't run in PRs.

Makes sense. Agreed! I'll discuss with Fraz

rabi-siddique commented 2 months ago

Turning this PR into a draft until #261 is merged. The test in this PR will be made part of the periodic CI run with emerynet.