cleanup tests for emerynet

Agoric / dapp-inter

User application for Agoric Inter Protocol—Vaults, BLD Boost, Liquidations, etc.

2 stars 7 forks source link

cleanup tests for emerynet #296

Closed rabi-siddique closed 1 month ago

rabi-siddique commented 1 month ago

The PR does the following:

Implements a test to reset the ATOM price to 12.34 in Emerynet, ensuring the resumption of normal operations.
Adds a test to remove the 150 IST bid in the liquidation happy path tests, to prevent any impact on subsequent test runs.

frazarshad commented 1 month ago

what if the tests fail, due to flakiness and the values arent reset?

rabi-siddique commented 1 month ago

what if the tests fail, due to flakiness and the values arent reset?

I have tested it locally with emerynet. There were no issues of flakiness or values not being reset. Assuming that the values are not reset in some cases, it won't give a problem ==> I think it will result in some test cases relevant to auction failure and that's it.

github-actions[bot] commented 1 month ago

Network: Commit: 44376d1b6f1ae0f8048c0b3b00439ca3cf559f7a Ref: refs/heads/main IPFS v1 hash: bafybeiaijcvsa3aen7dguwugnkitysqrpquuiczibdav47mjfzh5zwafqy CF - DWeb - 4EVERLAND