search

Agoric / dapp-inter

User application for Agoric Inter Protocol—Vaults, BLD Boost, Liquidations, etc.
2 stars 10 forks source link

passing env variables to the reusable workflow #301

Closed rabi-siddique closed 5 months ago

rabi-siddique commented 5 months ago

While running emerynet tests in CI for liquidation workflows, the environment variables were not picked up in the code. Their values were undefined.

After inspecting, I found that we need to pass the secrets to the reusable workflow from where it's being called. You can refer to this GitHub documentation on using inputs and secrets in a reusable workflow for more details.

In our CI setup, we have a file named reusable.workflow.yml, which is called in both liquidation.yml and liquidation-reconstitution.yml. In this PR, I am passing the secrets from these workflows to the reusable workflow.

github-actions[bot] commented 5 months ago

Network: Commit: a2f4f8edd2cb213f90783498ebd1ff548764b917 Ref: refs/heads/main IPFS v1 hash: bafybeib5d4jztfnwprgtshwvbwyoyz443igkxogywckhm3vpvlktbi26n4 CF - DWeb - 4EVERLAND

rabi-siddique commented 5 months ago

I wonder how this could have been detected earlier. Maybe with some config validation in the jobs.

That's a great point. Implementing configuration validation would be super helpful. I'll work on setting up the necessary configurations soon.