search

Agoric / dapp-inter

User application for Agoric Inter Protocol—Vaults, BLD Boost, Liquidations, etc.
2 stars 10 forks source link

Fix dapp-inter jumper page for instagoric #348

Closed samsiegart closed 2 months ago

samsiegart commented 2 months ago

Describe the bug

The instagoric pages e.g. https://emerynet.agoric.net/ have a link like:

Jumper Page: https://app.inter.trade/?network=emerynet

This now goes to the mainnet version of the app since the jumper was removed, so it doesn't connect to the desired network.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://emerynet.agoric.net/
  2. Click on Jumper Page: https://app.inter.trade/?network=emerynet
  3. You get to a version of dapp-inter that only works with mainnet

Expected behavior

The version of dapp-inter you land on connects to the expected network ?network=emerynet in this case, but also other networks depending on the param.

samsiegart commented 2 months ago

Proposed fix: Set up cloudflare page dapp-inter-test.pages.dev that serves the latest version of Agoric/dapp-inter and can use various networks depending on the URL param/dropdown. This isn't too much work because by default the dapp will support multiple networks and url params to specify the network, it only disables it when the network is specified in a build variable for production.

Then we can edit the instagoric pages to link to dapp-inter-test.pages.dev with the correct url param.

samsiegart commented 2 months ago

We now have dapp-inter-test.pages.dev which supports various networks:

dapp-inter-test.pages.dev?network=xnet dapp-inter-test.pages.dev?network=emerynet Etc.

I'm not sure how to change the links in the instagoric pages like https://emerynet.agoric.net/ though