search

Agoric / dapp-inter

User application for Agoric Inter Protocol—Vaults, BLD Boost, Liquidations, etc.
2 stars 10 forks source link

Vaults E2E test should indicate mint "exceeds amount available" instead of generic failure #359

Open 0xpatrickdev opened 1 month ago

0xpatrickdev commented 1 month ago

What is the Problem Being Solved?

When running Vaults E2E tests, it can fail if the mint limit is exceeded. It is outside the scope of the test to adjust the mint limit, but we can surface the error earlier. Currently, the test output does not surface a helpful error message and the runner needs to inspect the video artifact.

exceed-amount-avail

Description of the Design

When opening a vault, ensure "Exceeds amount available" text is not on the screen. If it is, fail the test with a message that indicates this specific failure. Currently, timed out retrying after 30050ms: 'cy.click()' failed because this element is 'disabled' is the only clue.

Security Considerations

Test Plan

0xpatrickdev commented 1 month ago

P.S. the artifact was really helpful here - great idea!