search

Agoric / dapp-inter

User application for Agoric Inter Protocol—Vaults, BLD Boost, Liquidations, etc.
2 stars 10 forks source link

[UI] "A vault is at risk" warning #92

Closed arirubinstein closed 1 year ago

arirubinstein commented 1 year ago

Describe the bug

When one or more vaults are at risk of liquidation, the test at the top reads "A vault is at risk", referring to a singular vault when there are more than one vaults at risk.

If the information is available, include the number of vaults that are at risk of liquidation, and if not, pluralize the warning to handle both cases of 1 vault or 2

bafybeiaw6ll7gyrqni4dd2cj5ns5twqznlrvql3vngh2vi3cuzot4d47uq.ipfs.cf-ipfs.com

Screenshot 2023-03-29 at 10 38 38 AM
otoole-brendan commented 1 year ago

@samsiegart I'm leaning towards updating this warning to 'One or more vaults is at risk of liquidation...' to cover all cases. Thoughts?

samsiegart commented 1 year ago

@otoole-brendan We can detect if it's one or multiple and show different text in each case if that's preferable.

otoole-brendan commented 1 year ago

@samsiegart likely trivial but let's punt to V+1 to reduce noise for release