search

Agoric / dapp-offer-up

Offer Up is a simple Dapp for the Agoric smart contract platform that permits users to explore items for sale in a marketplace
6 stars 5 forks source link

feat: ui improvements #25

Closed 0xpatrickdev closed 8 months ago

0xpatrickdev commented 9 months ago

Still room for improvement, ideally the user shouldn't have to scroll, but I think this looks a little bit better:

Screenshot 2023-12-29 at 4 51 11 PM Screenshot 2023-12-29 at 4 50 54 PM
dckc commented 9 months ago

ideally the user shouldn't have to scroll

I'd like to see how it looks with the give / want side by side. Is it obvious to you how to do that?

dckc commented 9 months ago

Approving because it's an improvement.

Changing the UI makes it inconsistent with the docs, including the video walkthru. So it's not clear that we want to land lots of little improvements - do we update the docs and video each time? Having product make a conscious decision about whether this is the next update seems cost-effective.

cc @sufyaankhan @kbennett2000

dckc commented 8 months ago

... Having product make a conscious decision about whether this is the next update seems cost-effective.

@sufyaankhan says go.