fix: wallet connection and chainStorageWatcher

Agoric / dapp-offer-up

Offer Up is a simple Dapp for the Agoric smart contract platform that permits users to explore items for sale in a marketplace

6 stars 5 forks source link

fix: wallet connection and chainStorageWatcher #63

Closed 0xpatrickdev closed 9 months ago

0xpatrickdev commented 9 months ago

there was a regression in #57 that broke makeAgoricChainStorageWatcher - it needs to take an apiUrl instead of rpc
makeAgoricWalletConnection needs an rpc to work, and an api endpoint, so this change brings it up to date with the new @agoric/rpc changes
also ensures there's only one yarn.lock in the workspace

Tested manually as it'd be a bit of work to add testing with keplr. A more cost effective test in the interim could be a UI banner that shows if the instance was found (API only), and a test to see if it's present. That would validate chainStorageWatcher is working (and, the contract install). Edit: Seem something to this effect is tracked here: https://github.com/Agoric/dapp-offer-up/issues/46

0xpatrickdev commented 9 months ago

P.S. if you are testing manually, voteLatestProposalAndWait seems to consistently fail - out of gas.

Revisiting efforts to fix that upstream: https://github.com/Agoric/agoric-3-proposals/pull/73

dckc commented 9 months ago

...

also ensures there's only one yarn.lock in the workspace

any particular reason? I thought separating them was on purpose.

0xpatrickdev commented 9 months ago

...

also ensures there's only one yarn.lock in the workspace

any particular reason? I thought separating them was on purpose.

It's my interpretation after reading this article. When I was updating the @agoric/web-components (from the workspace root) I kept observing it having no effect on the ui lock file.

dckc commented 9 months ago

I don't think we want to use code from the contract package in the UI nor vice versa. And I'm pretty sure we want to be able to use new shiny stuff in the ui before issues that would complicate compatibility between the contract and the chain get addressed. But I'm OK dealing with all that outside this PR.

0xpatrickdev commented 9 months ago

I don't think we want to use code from the contract package in the UI nor vice versa. And I'm pretty sure we want to be able to use new shiny stuff in the ui before issues that would complicate compatibility between the contract and the chain get addressed.

In yarn classic I believe there's a nohoist key that can be parameterized in workspaces in package.json to achieve this. In more recent versions of yarn, there's a nmHoistingLimits param that goes in .yarnrc.yml.