search

Agoric / dapp-offer-up

Offer Up is a simple Dapp for the Agoric smart contract platform that permits users to explore items for sale in a marketplace
6 stars 5 forks source link

chore: update ses package version to 1.3.0 #66

Closed rabi-siddique closed 7 months ago

rabi-siddique commented 7 months ago

fixes https://github.com/Agoric/dapp-offer-up/issues/67

The Offer-Up DAPP had loading issues on the latest versions of Brave and Chrome. To address this, I upgraded the ses package to version 1.3.0, resolving the compatibility issue.

rabi-siddique commented 7 months ago

Thanks Rabi! Mind also updating the version in ui/package.json?

Thanks for pointing it out, Sam. Done!

otoole-brendan commented 7 months ago

Created https://github.com/Agoric/dapp-offer-up/issues/67 as the issue to track this PR

samsiegart commented 7 months ago

@rabi-siddique Looks like cd ui && yarn build is failing due to an unused @ts-expect-error (I guess with the new ses version the exception is unneeded). I tried removing this line and it built locally: https://github.com/rabi-siddique/rs-dapp-offer-up/blob/3fddc34be347b55747c96a094448f022b03454ab/ui/src/installSesLockdown.ts#L6

Would you be able to remove that line in your fork? Then we can push this. Thanks!

rabi-siddique commented 7 months ago

@samsiegart Done. Thanks for inspecting. I've removed the line and the build works properly on local.