search

Agoric / dapp-offer-up

Offer Up is a simple Dapp for the Agoric smart contract platform that permits users to explore items for sale in a marketplace
6 stars 5 forks source link

chore: add SKIP_EXTENSION_SETUP flag to avoid duplicate wallet setup #79

Closed rabi-siddique closed 6 months ago

rabi-siddique commented 6 months ago

In end-to-end test cases, the wallet is set up twice because @agoric/synpress has code in the before hook that sets up the wallet before running tests. Check the code here.

However, since there is a specific test for setting up the wallet in dapp-offer-up in this file, we can skip the setup done by @agoric/synpress by setting the SKIP_EXTENSION_SETUP environment variable to true. This avoids redundant wallet setups.

rabi-siddique commented 6 months ago

I'm a little swapped out on the details, but this looks pretty low risk in any case.

We can set up a meeting sometime and discuss this? :)