Making Offer-up Work with GHCS

Agoric / dapp-offer-up

Offer Up is a simple Dapp for the Agoric smart contract platform that permits users to explore items for sale in a marketplace

6 stars 5 forks source link

Making Offer-up Work with GHCS #91

Closed amessbee closed 2 months ago

amessbee commented 3 months ago

Changes include:

script to make ports visible
.devcontainer directory and file
addition of env variables for domain and codespace name
fix RPC and API ENDPOINTS in UI for wallet connection
instructions addition in README

amessbee commented 3 months ago

@rabi-siddique can you please review this. @mujahidkay has already tested it, and I think we can merge it after you get to test it and find it reasonably stable. I added a few instructions in main README.md apart from other GHCS related changes. Thanks.

rabi-siddique commented 3 months ago

Getting CORS error while connecting to the wallet when using codespace:

rabi-siddique commented 3 months ago

My bad. I did not make the ports public. After making the ports public, I was able to connect the wallet and make the offer. There was an element of flakiness too but I am assuming it was due to my Internet. Will give it another try in a while.

Looks good overall :)