Agoric / documentation

User documentation
https://agoric.com/documentation/
Apache License 2.0
14 stars 38 forks source link

feat: github action to integrate/publish endo and agoric-sdk reference docs too #1038

Closed LuqiPan closed 3 months ago

LuqiPan commented 3 months ago

This PR will make reference docs for both endojs/endo and agoric/agoric-sdk repos available on docs.agoric.com.

Some finer prints:

cloudflare-pages[bot] commented 3 months ago

Deploying documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: ba4232f
Status: ✅  Deploy successful!
Preview URL: https://97e1e3c9.documentation-7tp.pages.dev
Branch Preview URL: https://927-reference-docs-in-search.documentation-7tp.pages.dev

View logs

github-actions[bot] commented 3 months ago

Cloudflare Pages Preview URL: https://3c691980.documentation-7tp.pages.dev

github-actions[bot] commented 3 months ago

Cloudflare Pages Preview URL: https://40e7b3f7.documentation-7tp.pages.dev

dckc commented 3 months ago

we will lose the lovely cloudflare-pages bot and its handy comment and links

That is a big loss.

We seem to still get comments with preview links: https://github.com/Agoric/documentation/pull/1038#issuecomment-2024063931

It seems to only provide per-commit preview links and not per-branch links that update with new commits. I'll miss that. But I think I can deal.

LuqiPan commented 3 months ago

Update:

We're going to submodules and back to build with Cloudflare (and thus Cloudflare Pages bot is working again), PR description updated too

turadg commented 3 months ago

Cloudflare Pages bot is working again and we're using submodules now. Let me know if you have additional comments, but for now I'm optimizing for getting this PR merged in.

👍