search

Agoric / documentation

User documentation
https://agoric.com/documentation/
Apache License 2.0
14 stars 38 forks source link

uploading required screenshots for UI component docs #1073

Closed otoole-brendan closed 1 month ago

otoole-brendan commented 2 months ago

Screenshots that are needed for UI component documentation

cloudflare-pages[bot] commented 2 months ago

Deploying documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 936bcdb
Status: ✅  Deploy successful!
Preview URL: https://498d74a5.documentation-7tp.pages.dev
Branch Preview URL: https://otoole-brendan-uicomponents.documentation-7tp.pages.dev

View logs

github-actions[bot] commented 2 months ago

Cloudflare deployment logs are available here

dckc commented 2 months ago

do these belong in the /getting-started/ directory?

dckc commented 2 months ago

Also, any particular reason to land this PR separately from #1074? This PR won't result in any visible changes to the docs.

otoole-brendan commented 2 months ago

@dckc #1074 points to these .png files that need to be in the assets file before displaying correctly. I wasn't aware I could upload the files as part of #1074 - that would have been the better thing to do. But per your point (and my other comment on #1074) - it sounds like these need to be in their own assets file and not 'Getting Started' if I want them on the same hierarchy/level as 'Getting Started', not within

kbennett2000 commented 1 month ago

@otoole-brendan - Maybe a folder under main/guides for ui related docs? Then it would live at the same level as getting started...

otoole-brendan commented 1 month ago

Redundant due to https://github.com/Agoric/documentation/pull/1084