Closed amessbee closed 1 month ago
Latest commit: |
ecb07fb
|
Status: | ✅ Deploy successful! |
Preview URL: | https://569ff001.documentation-7tp.pages.dev |
Branch Preview URL: | https://ms-update-orch-concepts.documentation-7tp.pages.dev |
Cloudflare deployment logs are available here
For the side nav - "takeaway x:" seems unnecessary, I would just title and label it "Starting a Local Chain" and update the other items.
There is a lot of truncation on the right side nav, where the first words are more generic and the truncated part seems more important - consider cutting those words down so we can see the full title
Example: "Creating your Dapp from a Template" -> "Creating from a Template" Example: "Starting the Dapp Smart Contract" -> "Starting the Smart Contract"
or visit https://classic.yarnpkg.com/en/docs/install for more information -> or visit the official yarn package
@mitdralla thanks for your comments. They are very helpful and I or @mujahidkay will create a separate issue based on your feedback. My current PR is about a (key concepts and APIs) page in our new orchestration section. If you can also provide feedback on that it would be great. Below is a direct link to the updated page that needs to be reviewed:
Sorry for the confusion - I should have been clearer when I requested feedback. Looking forward.
One more item which is minor - there is a missing space: "asAmountconverts a denom amount to an Amount with a brand."
Removing myself. This is DevRel purview.
@Jovonni thanks a lot for detailed review and comments. In essence, what we are doing here, everything that is not absolutely necessary for devs and posting it in a separate page: PR #1209.
We want this page to be magical and really abstract out all the details, conveying the message that if you need to orchestrate it is as simple as calling getChain
, makeAccount
, and then tansfer
for you and Agoric will take care of everything under-the-hood, and BTW if you need to know what's going on under-the-hood, here is an other page with details.
WDYT?
LGTM 🚀 , this is the only thing to address: https://github.com/Agoric/documentation/pull/1201/files#r1755891367
@Jovonni this comment by @toliaqat has already been addressed - if you look at the file chainHub
section already has two subsections. Let me know if there are any further comments.
Here is a list of changes:
Orchestration Key Concept Page Rendered
Refs: