Agoric / documentation

User documentation
https://agoric.com/documentation/
Apache License 2.0
15 stars 38 forks source link

feat(vitepress): updates site to use vitepress #971

Closed 0xpatrickdev closed 4 months ago

0xpatrickdev commented 5 months ago

closes: #972 refs: #609

Summary

To Do

Screenshot 2024-02-08 at 11 44 50 PM Screenshot 2024-02-08 at 11 39 18 PM Screenshot 2024-02-08 at 11 41 00 PM Screenshot 2024-02-08 at 11 40 21 PM
cloudflare-pages[bot] commented 5 months ago

Deploying documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: b1eed18
Status: ✅  Deploy successful!
Preview URL: https://65175600.documentation-7tp.pages.dev
Branch Preview URL: https://pc-vitepress.documentation-7tp.pages.dev

View logs

dckc commented 5 months ago

cloudflare failure looks like:

13:40:16.942 Error: Output directory "main/.vuepress/dist" not found.

0xpatrickdev commented 5 months ago

cloudflare failure looks like:

13:40:16.942 Error: Output directory "main/.vuepress/dist" not found.

I think the CI job is managed elsewhere (i.e., not source control)? Changing .vuepress -> .vitepress should make it pass. We can do this once everything is reviewed as it would after other PR's

dckc commented 5 months ago

also fixes #609 ?

0xpatrickdev commented 5 months ago

Deployed something here for the interim: https://65cac5889558bd35423c70e1--beautiful-lolly-46c6b2.netlify.app/

I used the output of yarn docs:build + _redirects. Netlfiy and Cloudflare seem to have the same _redirects structure.

image
0xpatrickdev commented 5 months ago

also fixes #609 ?

I did not tackle eslint in this, but can update the PR body with refs. #965 seems like it also contributes to #609

dckc commented 4 months ago

horizontal margins look goofy... including a scrollbar. important

image

0xpatrickdev commented 4 months ago

To merge this, we need to change the Build Output Directory in the cloudflare dash from /main/.vuepress/dist to /dist. The yarn docs:build-cf command (which copies _redirects into /dist) should stay the same.

We could make this deploy from /main/.vuepress/dist, but seems worthwhile to use a more generic /dist.