search

Agoric / faucet

Agoric Bot
3 stars 2 forks source link

faucet-helper.sh is hard to test #6

Open dckc opened 3 years ago

dckc commented 3 years ago

The faucet-helper.sh script was a quick-and-dirty approach, but with issues such as https://github.com/Agoric/testnet-notes/issues/25, we're considering investing a bit more.

For example, Dean writes:

we should plan to add some automation testing to faucet. it's likely to exist for a while.

With some help from @michaelfig , I broke ground on using cosmjs to send tokens, in an effort to replace faucet-helper.sh with something that is more consistent with our unit testing norms.

This may also help with related plans...

  // We hope to move to CosmJS with our own IBC implementation for all our light
  // client + transaction needs.

-- https://github.com/Agoric/agoric-sdk/blob/master/packages/solo/src/chain-cosmos-sdk.js#L284-L285

yelllowsin commented 3 years ago

@dckc I am still having issues with the faucet, can't get tokens to be delivered to this address. I am feeling hopeless already, I have tried many times, but still none worked for me: https://testnet.explorer.agoric.net/account/agoric1qr2s775y7umrm90ykjtfnhyk76zsrapx3z2xm8

I am not sure it is related to this issue, but it was the only one I found opened for the faucet at the moment.

yelllowsin commented 3 years ago

Here another example of RUN tokens that should have been delivered but are not at the destination address: https://testnet.explorer.agoric.net/transactions/9EF1AAFC10A92C6B195A6B438894D5372BEB16A5D6CE6F2C53121BDC2B34FD04

dckc commented 3 years ago

I am not sure it is related to this issue, but it was the only one I found opened for the faucet at the moment.

I suggest making a new issue, then.