search

Agoric / layer-cake

Class/traits-like composition of objects-as-closures
Apache License 2.0
8 stars 4 forks source link

Solution without generators #4

Closed DavidBruant closed 4 years ago

DavidBruant commented 4 years ago

I tried it mostly for fun Sharing the result in case it's useful All tests pass, but i'm not sure there are enough tests to consider this solution valid

Fixes #3

Chris-Hibbert commented 4 years ago

Thanks, David! I like the style of invocation here much better than the generator style. I'll leave it to MarkM to opine on whether this is secure in the way he's looking for and other language-level issues.

erights commented 4 years ago

Could you also update the README to match? Thanks.

DavidBruant commented 4 years ago

After the first skim I was concerned whether you preserved the security properties of the original

Is there a way to capture all or some of these in the form of one or a couple of unit tests?

Could you also update the README to match?

ok, i'll do that

DavidBruant commented 4 years ago

I'm not fully sure about the wording of "intermediate function"

DavidBruant commented 4 years ago

@erights ping (in case you haven't seen it)

DavidBruant commented 4 years ago

i'm realizing now i do not have the rights to merge a PR on this repo...