search

Agoric / testnet-load-generator

A dapp that generates somewhat realistic loads for testnet
Apache License 2.0
7 stars 7 forks source link

Refactor loadgen to handle IST #80

Closed mhofman closed 2 years ago

mhofman commented 2 years ago

https://github.com/Agoric/agoric-sdk/issues/5326 is renaming RUN -> IST. This PR refactors the loadgen to no longer hardcode RUN, and instead names anything related with "stable". Then it adds a dynamic fallback from IST to RUN for backwards compatibility.

Successfully tested locally the "local-chain" variant against the same revisions as https://github.com/Agoric/testnet-load-generator/pull/71, as well as the current master of agoric-sdk: 12e61941. The "testnet" variant against the same agoric-sdk master revision is also passing, allowing a safe merge without breaking agoric-sdk's CI.

Tested against the IST rename branch (4800-unRUN).

mhofman commented 2 years ago

Older revisions with Zoe fee purse are failing. I need to decide how ugly of a patch I want to handle that case.

mhofman commented 2 years ago

Looks good, but I'd strongly encourage you to use keyword instead of symbol.

I went by the nomenclature @dckc seem to have adopted in his PR. I did however just switch to a "keyword" name for vaults. Currently the keyword for those is still RUN which is obviously wrong, so making this PR draft until that gets settled.

mhofman commented 2 years ago

Rebased PR on latest main, and update to use the Minted keyword for vaults according to https://github.com/Agoric/agoric-sdk/pull/5585. However that PR does not currently incorporate https://github.com/Agoric/agoric-sdk/pull/5332 which this was originally based against, so right now it'll not work (I've verified that this PR still runs correctly against the 5328-IST-boot branch if the vault keyword is forced to RUN in the vault task agent).