Agoric / ui-kit

Components and tools for building graphical UIs
https://ui-kit-dwm.pages.dev/
Apache License 2.0
3 stars 3 forks source link

feat: added network notice banner as a resuable component #112

Closed frazarshad closed 5 months ago

frazarshad commented 5 months ago

closes: #114

Description

This PR adds NetworkBanner (originally implemented in this PR) as a reusable component for dapps. The purpose of this component is to query the /network-config endpoint to find any notices and display them.

The use of this component dapp-econ-gov can be seen in this PR https://github.com/Agoric/dapp-econ-gov/pull/104

How to test

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

samsiegart commented 5 months ago

In reference to https://github.com/Agoric/dapp-psm/pull/94, I'm having trouble testing with yarn link as well (probably since we updated to yarn v4). I'm eager to put an example dapp in this package (https://github.com/Agoric/ui-kit/issues/86) so we can test new components easier.

cloudflare-workers-and-pages[bot] commented 5 months ago

Deploying ui-kit with  Cloudflare Pages  Cloudflare Pages

Latest commit: ab2cc72
Status: ✅  Deploy successful!
Preview URL: https://24c15ad2.ui-kit-dwm.pages.dev
Branch Preview URL: https://feat-notice-banner.ui-kit-dwm.pages.dev

View logs

frazarshad commented 5 months ago

In reference to Agoric/dapp-psm#94, I'm having trouble testing with yarn link as well (probably since we updated to yarn v4). I'm eager to put an example dapp in this package (#86) so we can test new components easier.

yarn link was also troublesome for me. i've added instructions in the description on how to test these changes

frazarshad commented 5 months ago

Can you add the issue to the PR description please? It would be helpful to see the requirements.

No issue exists previously. created one and linked it in the PR