Closed samsiegart closed 1 year ago
refs https://github.com/Agoric/agoric-sdk/issues/6870
Basing this off of https://github.com/Agoric/ui-kit/tree/sam-cleanup until that's merged
Wrote some unit tests, which pass. Also tested manually with yarn link in https://github.com/Agoric/dapp-inter/pull/140. When not mocking @agoric deps and trying to lockdown, I encountered the following error: https://gist.github.com/samsiegart/90182d0f3eb0240c9b24db8befafb7d0. I don't think it's worth the time right now to investigate further or try to factor away @agoric/notifier, the performance impact on UIs is more critical imo
yarn link
@agoric
lockdown
@agoric/notifier
refs https://github.com/Agoric/agoric-sdk/issues/6870
Basing this off of https://github.com/Agoric/ui-kit/tree/sam-cleanup until that's merged
Testing Considerations
Wrote some unit tests, which pass. Also tested manually with
yarn linkin https://github.com/Agoric/dapp-inter/pull/140. When not mocking@agoricdeps and trying tolockdown, I encountered the following error: https://gist.github.com/samsiegart/90182d0f3eb0240c9b24db8befafb7d0. I don't think it's worth the time right now to investigate further or try to factor away@agoric/notifier, the performance impact on UIs is more critical imo