Agoric / ui-kit

Components and tools for building graphical UIs
https://ui-kit-dwm.pages.dev/
Apache License 2.0
3 stars 3 forks source link

ci: require js extensions on local imports #77

Closed samsiegart closed 8 months ago

samsiegart commented 8 months ago

We need to use .js when importing local typescript files for ESM compatibility. https://github.com/Agoric/ui-kit/pull/76 fixes this, but this PR adds an eslint plugin (thanks solana) to protect against breaking it again.

I looked into other options, like libraries that transform extensionless imports to .js automatically, but seems like .js extensions are a common pattern in typescript libraries, and it seems less risky to not muck around with the build process.

Example output:

Screenshot 2024-01-25 at 11 02 49 AM