When using the purses notifier from makeAgoricWalletConnection, it will notify updates intermittently even when no purses have changed. This is because it queries the bank periodically, and doesn't check if the actual results have changed or not since the last query, always triggering a new update.
This is problematic because it can lead to unnecessary re-renders in clients. It should check if the bank value is new before updating.
Note it also uses a chain storage watcher to watch vstorage for other non-bank purses, but this only updates when the values are new, so it's not part of the problem.
Describe the bug
When using the purses notifier from
makeAgoricWalletConnection, it will notify updates intermittently even when no purses have changed. This is because it queries the bank periodically, and doesn't check if the actual results have changed or not since the last query, always triggering a new update.This is problematic because it can lead to unnecessary re-renders in clients. It should check if the bank value is new before updating.
Note it also uses a chain storage watcher to watch vstorage for other non-bank purses, but this only updates when the values are new, so it's not part of the problem.